Skip to content

Update manager kustomization image - #6

Merged
tzumainn merged 1 commit into
osac-project:mainfrom
ajamias:image-kustomization
May 20, 2026
Merged

Update manager kustomization image#6
tzumainn merged 1 commit into
osac-project:mainfrom
ajamias:image-kustomization

Conversation

@ajamias

@ajamias ajamias commented May 20, 2026

Copy link
Copy Markdown
Contributor

Before, the image would be named controller which is the default name for operator images. There would be no way to distinguish this image name from other images with the same default name. This commit changes it to pull from ghcr.io/osac-project/host-management-openstack instead.

Before, the image would be named `controller` which is the default name
for operator images. There would be no way to distinguish this image
name from other images with the same default name. This commit changes
it to pull from ghcr.io/osac-project/host-management-openstack instead.
@ajamias
ajamias requested review from DanNiESh and tzumainn May 20, 2026 14:55
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

Review Change Stack

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration to retarget the controller image to a new container registry with the latest version tag.

Walkthrough

The pull request updates config/manager/kustomization.yaml to establish a complete Kubernetes kustomization manifest. The file now includes the required apiVersion: kustomize.config.k8s.io/v1beta1 and kind: Kustomization declarations, explicitly lists manager.yaml in the resources section, and introduces an images override that retargets the controller image from its default location to ghcr.io/osac-project/host-management-openstack:latest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update manager kustomization image' directly and accurately summarizes the main change: updating the kustomization manifest's image configuration.
Description check ✅ Passed The description explains the rationale for the change: replacing the generic 'controller' image name with a project-specific image reference from ghcr.io/osac-project/host-management-openstack.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/manager/kustomization.yaml`:
- Line 8: The kustomization sets newTag: latest which makes deployments
non-reproducible; replace the mutable "latest" with an immutable image tag or,
preferably, an image digest (sha256) so the operator image is pinned. Update the
newTag value in kustomization.yaml (the newTag entry for the operator image) to
a concrete version string or digest and ensure your CI/CD injects the exact
tag/digest during release.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 495130c4-d706-4404-88a5-a00392ba6099

📥 Commits

Reviewing files that changed from the base of the PR and between d7283da and 83bbda9.

📒 Files selected for processing (1)
  • config/manager/kustomization.yaml

Comment thread config/manager/kustomization.yaml
Comment thread config/manager/kustomization.yaml

@tzumainn tzumainn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@tzumainn
tzumainn merged commit 3ad9e1a into osac-project:main May 20, 2026
5 checks passed
@ajamias
ajamias deleted the image-kustomization branch May 21, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants